fix(smus): Look for profile in both config and credentials files when adding region to profile#8522
Merged
laileni-aws merged 3 commits intoaws:masterfrom Jan 28, 2026
Merged
Conversation
|
| continue | ||
| } | ||
|
|
||
| const content = await fs.readFileText(filePath) |
Contributor
There was a problem hiding this comment.
Nit : we are reading file twice here and one for sections. I think it can be done in one fileread call
content = await fs.readFileText(filePath) and then
sections = parseIni(content, vscode.Uri.file(filePath))
Contributor
Author
There was a problem hiding this comment.
thanks, will fix it.
| const content = await fs.readFileText(filePath) | ||
|
|
||
| // Find the profile section boundaries using the startLines from parsed section | ||
| const profileStartLine = profileSection.startLines[0] |
Contributor
There was a problem hiding this comment.
can startLines be empty?
Contributor
Author
There was a problem hiding this comment.
No while profile section exists.
|
|
||
| // Find the profile section boundaries using the startLines from parsed section | ||
| const profileStartLine = profileSection.startLines[0] | ||
| const lines = content.split('\n') |
Contributor
There was a problem hiding this comment.
have you tested this in Windows as well? I believe worth testing
Contributor
Author
There was a problem hiding this comment.
Will make it os eol instead.
4ec2713 to
38e97e6
Compare
vpbhargav
approved these changes
Jan 23, 2026
bhavya2109sharma
approved these changes
Jan 26, 2026
ashishrp-aws
approved these changes
Jan 26, 2026
laileni-aws
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Solution
profileprefixTest
Updating profile with
profileprefix in config filebefore
after
feature/xbranches will not be squash-merged at release time.